Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Feature: overload endpoint#7

Merged
spacether merged 11 commits intoopenapi-json-schema-tools:masterfrom
EltonChou:feat_overload_endpoint
Oct 4, 2022
Merged

Feature: overload endpoint#7
spacether merged 11 commits intoopenapi-json-schema-tools:masterfrom
EltonChou:feat_overload_endpoint

Conversation

@EltonChou
Copy link
Copy Markdown
Contributor

Fix #4

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether
Copy link
Copy Markdown
Contributor

spacether commented Oct 3, 2022

@EltonChou want this to be a hacktoberfest PR?

@EltonChou
Copy link
Copy Markdown
Contributor Author

EltonChou commented Oct 3, 2022

@EltonChou want this to be a hacktoberfest PR?

Sure.

@spacether spacether added this to the 1.0.0 milestone Oct 4, 2022
Copy link
Copy Markdown
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the more specific type hints!

@spacether spacether merged commit f552198 into openapi-json-schema-tools:master Oct 4, 2022
@EltonChou EltonChou deleted the feat_overload_endpoint branch October 4, 2022 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] Add type overload for endpoint, if skip_deserialization = True -> api_client.ApiResponseWithoutDeserialization

2 participants